RC1.1

Code analyzer complete.
2017-10-13 09:23:51 +02:00
parent c807d2f792
commit 29e8cbb255
30 changed files with 122 additions and 30 deletions
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -0,0 +1,14 @@
+<component name="InspectionProjectProfileManager">
+  <profile version="1.0">
+    <option name="myName" value="Project Default" />
+    <inspection_tool class="LoggerInitializedWithForeignClass" enabled="false" level="WARNING" enabled_by_default="false">
+      <option name="loggerClassName" value="org.apache.log4j.Logger,org.slf4j.LoggerFactory,org.apache.commons.logging.LogFactory,java.util.logging.Logger" />
+      <option name="loggerFactoryMethodName" value="getLogger,getLogger,getLog,getLogger" />
+    </inspection_tool>
+    <inspection_tool class="SpellCheckingInspection" enabled="false" level="TYPO" enabled_by_default="false">
+      <option name="processCode" value="true" />
+      <option name="processLiterals" value="true" />
+      <option name="processComments" value="true" />
+    </inspection_tool>
+  </profile>
+</component>
--- a/.idea/inspectionProfiles/profiles_settings.xml
+++ b/.idea/inspectionProfiles/profiles_settings.xml
@@ -0,0 +1,7 @@
+<component name="InspectionProjectProfileManager">
+  <settings>
+    <option name="PROJECT_PROFILE" value="Project Default" />
+    <option name="USE_PROJECT_PROFILE" value="true" />
+    <version value="1.0" />
+  </settings>
+</component>
--- a/IntelliLang.xml
+++ b/IntelliLang.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="LanguageInjectionConfiguration">
    <option name="INSTRUMENTATION" value="ASSERT" />
--- a/_windows/git.xml
+++ b/_windows/git.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="Git.Application.Settings">
    <option name="myPathToGit" value="C:\Program Files\Git\cmd\git.exe" />
--- a/_windows/hg.xml
+++ b/_windows/hg.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="HgGlobalSettings">
    <option name="myHgExecutable" value="hg.exe" />
--- a/_windows/keymap.xml
+++ b/_windows/keymap.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="KeymapManager">
    <active_keymap name="$default" />
--- a/_windows/laf.xml
+++ b/_windows/laf.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="LafManager">
    <laf class-name="com.intellij.ide.ui.laf.darcula.DarculaLaf" />
--- a/androidEditors.xml
+++ b/androidEditors.xml
@@ -1,9 +1,11 @@
+<!--suppress ALL -->
+
 <application>
-  <component name="AndroidEditors">
-    <option name="state">
-      <GlobalState>
-        <option name="visible" value="false" />
-      </GlobalState>
-    </option>
-  </component>
+    <component name="AndroidEditors">
+        <option name="state">
+            <GlobalState>
+                <option name="visible" value="false" />
+            </GlobalState>
+        </option>
+    </component>
 </application>
--- a/androidStudioFirstRun.xml
+++ b/androidStudioFirstRun.xml
@@ -1,5 +1,7 @@
+<!--suppress ALL -->
+
 <application>
-  <component name="AndroidFirstRunPersistentData">
-    <version>1</version>
-  </component>
+    <component name="AndroidFirstRunPersistentData">
+        <version>1</version>
+    </component>
 </application>
--- a/app/lint.xml
+++ b/app/lint.xml
@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<lint>
+    <issue id="IconLauncherShape">
+        <ignore path="src/main/res/mipmap-hdpi/sdn_logo.png" />
+        <ignore path="src/main/res/mipmap-mdpi/sdn_logo.png" />
+        <ignore path="src/main/res/mipmap-xhdpi/sdn_logo.png" />
+        <ignore path="src/main/res/mipmap-xxhdpi/sdn_logo.png" />
+        <ignore path="src/main/res/mipmap-xxxhdpi/sdn_logo.png" />
+    </issue>
+</lint>
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -1,5 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
    package="sdn.ucsandroidwidget">

    <uses-permission android:name="android.permission.INTERNET" />
@@ -7,12 +8,13 @@
    <uses-permission android:name="android.permission.WAKE_LOCK" />

    <application
-        android:allowBackup="true"
+        android:allowBackup="false"
        android:icon="@mipmap/sdn_logo"
        android:label="@string/app_name"
        android:roundIcon="@mipmap/sdn_logo"
        android:supportsRtl="true"
-        android:theme="@style/AppTheme">
+        android:theme="@style/AppTheme"
+        tools:ignore="GoogleAppIndexingWarning">
        <activity android:name=".MainActivity">
            <intent-filter>
                <action android:name="android.intent.action.MAIN" />
@@ -29,12 +31,13 @@
                android:resource="@xml/widget_provider_info" />
        </receiver>

-        <receiver android:name=".WidgetReceiver"
+        <receiver
+            android:name=".WidgetReceiver"
            android:exported="false">
            <intent-filter>
-                <action android:name="SDN_START"></action>
-                <action android:name="SDN_UN_LOCK"></action>
-                <action android:name="SDN_UPDATE"></action>
+                <action android:name="SDN_START" />
+                <action android:name="SDN_UN_LOCK" />
+                <action android:name="SDN_UPDATE" />
            </intent-filter>
        </receiver>

@@ -44,7 +47,7 @@
            android:exported="false"
            android:permission="android.permission.RECEIVE_BOOT_COMPLETED">>
            <intent-filter>
-                <action android:name="android.intent.action.BOOT_COMPLETED"/>
+                <action android:name="android.intent.action.BOOT_COMPLETED" />
                <category android:name="android.intent.category.DEFAULT" />
            </intent-filter>
        </receiver>
@@ -53,7 +56,7 @@
            android:name=".UDPIntentService"
            android:exported="false">
            <intent-filter>
-                <action android:name="SDN_SEND_UDP"></action>
+                <action android:name="SDN_SEND_UDP" />
            </intent-filter>
        </service>

--- a/app/src/main/res/layout/activity_main.xml
+++ b/app/src/main/res/layout/activity_main.xml
@@ -11,6 +11,7 @@
        android:layout_width="150dp"
        android:layout_height="40dp"
        android:layout_marginLeft="10dp"
+        android:layout_marginStart="10dp"
        android:layout_marginTop="8dp"
        android:hint="@string/hint_label_1"
        android:imeOptions="actionDone"
@@ -25,6 +26,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginLeft="8dp"
+        android:layout_marginStart="8dp"
        android:text="@string/label_timer"
        app:layout_constraintBaseline_toBaselineOf="@+id/tb_lbl0"
        app:layout_constraintLeft_toRightOf="@+id/tb_lbl0" />
@@ -33,6 +35,7 @@
        android:id="@+id/tb_lbl1"
        android:layout_width="150dp"
        android:layout_height="40dp"
+        android:layout_marginEnd="0dp"
        android:layout_marginRight="0dp"
        android:layout_marginTop="7dp"
        android:hint="@string/hint_label_2"
@@ -48,6 +51,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginLeft="8dp"
+        android:layout_marginStart="8dp"
        android:text="@string/label_timer"
        app:layout_constraintBaseline_toBaselineOf="@+id/tb_lbl1"
        app:layout_constraintLeft_toRightOf="@+id/tb_lbl1" />
@@ -57,6 +61,7 @@
        android:layout_width="150dp"
        android:layout_height="40dp"
        android:layout_marginBottom="16dp"
+        android:layout_marginEnd="117dp"
        android:layout_marginRight="117dp"
        android:hint="@string/hint_broadcast_IP"
        android:imeOptions="actionDone"
@@ -69,6 +74,7 @@
        android:id="@+id/tb_ID"
        android:layout_width="40dp"
        android:layout_height="40dp"
+        android:layout_marginEnd="8dp"
        android:layout_marginRight="8dp"
        android:hint="@string/hint_sender"
        android:imeOptions="actionDone"
@@ -83,6 +89,7 @@
        android:layout_width="101dp"
        android:layout_height="52dp"
        android:layout_marginLeft="5dp"
+        android:layout_marginStart="5dp"
        android:text="@string/label_save"
        app:layout_constraintBaseline_toBaselineOf="@+id/tb_IP"
        app:layout_constraintLeft_toRightOf="@+id/tb_IP" />
@@ -92,6 +99,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginLeft="8dp"
+        android:layout_marginStart="8dp"
        android:text="@string/label_D"
        android:textSize="18sp"
        app:layout_constraintBaseline_toBaselineOf="@+id/tb_lbl0"
@@ -101,6 +109,7 @@
        android:id="@+id/textView3"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
+        android:layout_marginEnd="8dp"
        android:layout_marginRight="8dp"
        android:text="@string/label_ID"
        android:textSize="18sp"
@@ -111,6 +120,7 @@
        android:id="@+id/textView4"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
+        android:layout_marginEnd="8dp"
        android:layout_marginRight="8dp"
        android:text="@string/label_IP"
        android:textSize="18sp"
@@ -122,6 +132,7 @@
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_marginLeft="8dp"
+        android:layout_marginStart="8dp"
        android:text="@string/label_D"
        android:textSize="18sp"
        app:layout_constraintBaseline_toBaselineOf="@+id/tb_lbl1"
@@ -132,6 +143,7 @@
        android:layout_width="20dp"
        android:layout_height="40dp"
        android:layout_marginLeft="0dp"
+        android:layout_marginStart="0dp"
        android:ems="10"
        android:hint="@string/hint_ID_0"
        android:imeOptions="actionDone"
@@ -146,6 +158,7 @@
        android:layout_width="20dp"
        android:layout_height="40dp"
        android:layout_marginLeft="0dp"
+        android:layout_marginStart="0dp"
        android:ems="10"
        android:hint="@string/hint_ID_1"
        android:imeOptions="actionDone"
--- a/app/src/main/res/layout/widget_provider.xml
+++ b/app/src/main/res/layout/widget_provider.xml
@@ -19,19 +19,19 @@
        android:text="@string/text_edit_default"
        android:textAllCaps="false"
        android:textAppearance="@android:style/TextAppearance.Large"
-        android:textSize="36dp"
+        android:textSize="36sp"
        android:textStyle="bold" />

    <ImageView
        android:id="@+id/btn_1"
-        android:contentDescription="@string/button_1"
        android:layout_width="60dp"
        android:layout_height="60dp"
+        android:layout_alignParentEnd="true"
+        android:layout_alignParentRight="true"
+        android:layout_alignParentTop="true"
        android:layout_gravity="center_vertical|start"
        android:background="@mipmap/sdn_unknown"
-        android:layout_alignParentTop="true"
-        android:layout_alignParentRight="true"
-        android:layout_alignParentEnd="true" />
+        android:contentDescription="@string/button_1" />

    <TextView
        android:id="@+id/lbl_2"
@@ -44,18 +44,18 @@
        android:text="@string/text_edit_default"
        android:textAllCaps="false"
        android:textAppearance="@android:style/TextAppearance.Large"
-        android:textSize="36dp"
+        android:textSize="36sp"
        android:textStyle="bold" />

    <ImageView
        android:id="@+id/btn_2"
-        android:contentDescription="@string/button_2"
        android:layout_width="60dp"
        android:layout_height="60dp"
+        android:layout_alignParentEnd="true"
+        android:layout_alignParentRight="true"
+        android:layout_below="@+id/btn_1"
        android:layout_gravity="center_vertical|start"
        android:background="@mipmap/sdn_unknown"
-        android:layout_below="@+id/btn_1"
-        android:layout_alignParentRight="true"
-        android:layout_alignParentEnd="true" />
+        android:contentDescription="@string/button_2" />

 </RelativeLayout>
--- a/app/src/main/res/xml/widget_provider_info.xml
+++ b/app/src/main/res/xml/widget_provider_info.xml
@@ -4,5 +4,4 @@
    android:minHeight="110dp"
    android:minWidth="280dp"
    android:previewImage="@mipmap/sdn_logo"
-    android:updatePeriodMillis="1800000"
-    ></appwidget-provider>
+    android:updatePeriodMillis="1800000" />
--- a/colors.scheme.xml
+++ b/colors.scheme.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="EditorColorsManagerImpl">
    <global_color_scheme name="Darcula" />
--- a/customization.xml
+++ b/customization.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="com.intellij.ide.ui.customization.CustomActionsSchema">
    <group value="AddToISuite" is_action="true" action_type="-1" position="0">
--- a/debugger.renderers.xml
+++ b/debugger.renderers.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="NodeRendererSettings">
    <option name="HEX_VIEW_ENABLED" value="false" />
--- a/debugger.xml
+++ b/debugger.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="DebuggerSettings">
    <option name="TRACING_FILTERS_ENABLED" value="true" />
--- a/diff.xml
+++ b/diff.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="DiffSettings">
    <option name="PLACES_MAP">
--- a/editor.codeinsight.xml
+++ b/editor.codeinsight.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="CodeInsightSettings">
    <option name="AUTO_POPUP_JAVADOC_INFO" value="true" />
--- a/find.xml
+++ b/find.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="FindSettings">
    <option name="customScope" value="Project 'Deur_Widget'" />
--- a/github_settings.xml
+++ b/github_settings.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="GithubSettings">
    <option name="LOGIN" value="xsl-sdnt" />
--- a/gradle.run.settings.xml
+++ b/gradle.run.settings.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="GradleSystemRunningSettings">
    <option name="preferredTestRunner" value="PLATFORM_TEST_RUNNER" />
--- a/ide.general.xml
+++ b/ide.general.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="GeneralSettings">
    <option name="confirmExit" value="false" />
--- a/inspection/Default.xml
+++ b/inspection/Default.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <inspections profile_name="Default" version="1.0">
  <option name="myName" value="Default" />
 </inspections>
--- a/jdk.table.xml
+++ b/jdk.table.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="ProjectJdkTable">
    <jdk version="2">
--- a/notifications.xml
+++ b/notifications.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="NotificationConfiguration">
    <notification groupId="File Watcher Messages" />
--- a/project.default.xml
+++ b/project.default.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="ProjectManager">
    <defaultProject>
--- a/ui.lnf.xml
+++ b/ui.lnf.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="UISettings">
    <option name="HIDE_TOOL_STRIPES" value="false" />
--- a/web-browsers.xml
+++ b/web-browsers.xml
@@ -1,3 +1,5 @@
+<!--suppress ALL -->
+
 <application>
  <component name="WebBrowsersConfiguration">
    <browser id="98ca6316-2f89-46d9-a9e5-fa9e2b0625b3" name="Chrome" family="CHROME" />